CurlTransportSuccessAsHttpSuccess

warning native off by default

Group: Probable bugs

Detect curl_exec success used as the sole condition for a literal successful return when no HTTP response-code validation occurs for that handle.

Example

<?php
function bad($url) { $ch = curl_init('https://example.invalid/api'); if (curl_exec($ch) !== false) { return true; } return false; }

Reported:

• line 2: Check the HTTP response status before reporting success.

Detection

• Report curl_exec success used as the sole condition for a literal successful return when no HTTP response-code validation occurs for that handle.
• Resolve builtin calls and named arguments before checking the contract. Project-local callees are considered only when their bodies or immutable summaries establish the required facts. The default is disabled; enable only when the stated intent matches the application.
• For flow-dependent conditions, require a reachable source-to-use path with no intervening invalidation. Unknown calls, ambiguous aliases or recursion cannot establish definite facts. When the proof is inconclusive, nothing is reported.

Exceptions (no report)

• Non-HTTP protocols, configured fail-on-error, explicit permitted status checks, and escaped handles invalidate the report.
• Unresolved targets, incomplete required facts, suppressed findings and PHP versions lacking the referenced API or language feature produce no report. User declarations shadowing builtin names are not builtin contracts.

Fix

No automatic fix: accepted HTTP statuses are application-specific.

PHP versions

Apply only on PHP versions supporting the referenced APIs and syntax (within PHP 5.3–8.5). Builtin behavior and argument contracts follow the configured PHP version. Extension-specific calls require resolved extension API symbols; do not treat same-named application functions as extension calls.

Options

None. Enable or disable this rule through normal rule configuration.

Configure

In custos.json:

{
  "rules": {
    "CurlTransportSuccessAsHttpSuccess": {
      "enabled": true
    }
  }
}

Suppress

Before the statement or declaration (or the first statement of the file):

// @custos-ignore CurlTransportSuccessAsHttpSuccess