ZipCloseFailureUnchecked

warning native off by default

Group: Probable bugs

Writing an archive is not complete until finalization succeeds. Check the close result before returning success. This inspection is disabled by default because the intended policy or use can vary.

Example

<?php
function archive($p){$z=new ZipArchive();if($z->open($p,ZipArchive::CREATE)!==true){return false;}$z->addFromString("a.txt","a");$z->close();return true;}

Reported:

• line 2: Check archive finalization before returning success.

Detection

• A proven ZipArchive receiver has a successful checked open, then addFromString/addFile mutation, and a discarded close result followed by unconditional literal true return from the containing function. Highlight close; no success-name heuristics.
• The initial supported proof is consecutive checked-open rejection guard, archive mutation, discarded close, and return true statements.
• Resolve builtin functions, classes, constants and methods; user-defined lookalikes are excluded. Follow only bounded local proof in one lexical scope.
• Emit one finding per violating operation, not per supporting evidence statement. When the proof is inconclusive, nothing is reported.

Exceptions (no report)

• Do not report unresolved or shadowed builtin names, unknown values, or incomplete receiver/type provenance. Unknown calls, aliases escaping, and intervening writes invalidate local proof. Similar code outside the stated detection contract is not a finding.
• Both standard suppression forms suppress this native ID.

Fix

None. Choosing a repair requires intent or additional runtime information.

PHP versions

Available throughout supported PHP 5.3–8.5 where the referenced builtin/extension is available. Respect syntax/version-specific receiver contracts; unavailable APIs are not this rule’s concern.

Configure

In custos.json:

{
  "rules": {
    "ZipCloseFailureUnchecked": {
      "enabled": true
    }
  }
}

Suppress

Before the statement or declaration (or the first statement of the file):

// @custos-ignore ZipCloseFailureUnchecked